feat(http, model): Add placeholder, content-type, and flags to embeds - #2566
Open
goodspark wants to merge 4 commits into
Open
feat(http, model): Add placeholder, content-type, and flags to embeds#2566goodspark wants to merge 4 commits into
goodspark wants to merge 4 commits into
Conversation
github-actions
Bot
added
c-model
goodspark
changed the title
Closes twilight-rs#2524 This adds the optional content-type, placeholder, and media flag fields to the embed image and video structs.
goodspark
marked this pull request as ready for review
July 28, 2026 19:05
goodspark
commented
Jul 28, 2026
| @@ -0,0 +1,84 @@ | |||
| use bitflags::bitflags; | |||
Author
There was a problem hiding this comment.
I just copied and modified the AttachmentFlags code here, since it's basically the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2524
This adds the optional content-type, placeholder (see the image or video type docs in that section) (essentially a small thumbnail), and media flag fields to the embed image and video types as well as the placeholder fields to the attachment type.