Implement http requests related to soundboard - #2528
Open
Erk- wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
c-http
raventhyme
requested changes
Jul 12, 2026
raventhyme
left a comment
raventhyme
left a comment
Member
There was a problem hiding this comment.
Discord API docs commit documenting this: discord/discord-api-docs@90b8e8c
| pub const SOUNDBOARD_SOUND_NAME_LENGTH_MAX: usize = 100; | ||
|
|
||
| /// Minimum length of a soundboard sound's name. | ||
| pub const SOUNDBOARD_SOUND_NAME_LENGTH_MIN: usize = 1; |
Member
There was a problem hiding this comment.
Suggested change
| pub const SOUNDBOARD_SOUND_NAME_LENGTH_MIN: usize = 1; | |
| pub const SOUNDBOARD_SOUND_NAME_LENGTH_MIN: usize = 2; |
| }; | ||
|
|
||
| /// Maximum length of a soundboard sound's name. | ||
| pub const SOUNDBOARD_SOUND_NAME_LENGTH_MAX: usize = 100; |
Member
There was a problem hiding this comment.
Suggested change
| pub const SOUNDBOARD_SOUND_NAME_LENGTH_MAX: usize = 100; | |
| pub const SOUNDBOARD_SOUND_NAME_LENGTH_MAX: usize = 32; |
| #[derive(Debug)] | ||
| #[non_exhaustive] | ||
| pub enum SoundboardValidationErrorType { | ||
| /// The length of the name is either fewer than 2 characters or more than 32 |
Member
There was a problem hiding this comment.
This doc comment can drift if the constants change. Elsewhere we reference constants.
| /// The length of the name is either fewer than 2 characters or more than 32 | ||
| /// characters. | ||
| NameInvalid, | ||
| /// The volume can be between 0 and 1 inclusive. |
| pub guild_id: Option<Id<GuildMarker>>, | ||
| /// Wwhether this sound can be used, may be false due to loss of Server Boosts. | ||
| pub available: bool, | ||
| /// Uhe user who created this sound. |
Member
There was a problem hiding this comment.
Suggested change
| /// Uhe user who created this sound. | |
| /// The user who created this sound. |
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub emoji_name: Option<String>, | ||
| /// The id of the guild this sound is in. | ||
| pub guild_id: Option<Id<GuildMarker>>, |
Member
There was a problem hiding this comment.
Meanwhile, Discord documents this as being an optional key but not as a nullable string. This should be
Suggested change
| pub guild_id: Option<Id<GuildMarker>>, | |
| #[serde(skip_serializing_if = "Option::is_none")] | |
| pub guild_id: Option<Id<GuildMarker>>, |
Comment on lines
+22
to
+23
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub emoji_name: Option<String>, |
Member
There was a problem hiding this comment.
Discord documents this as being a nullable string but not as an optional key
Suggested change
| #[serde(skip_serializing_if = "Option::is_none")] | |
| pub emoji_name: Option<String>, | |
| pub emoji_name: Option<String>, |
| VolumeInvalid, | ||
| } | ||
|
|
||
| /// The name of a soundboard sound can have a length between 2 and 32 characters. |
| } | ||
| } | ||
|
|
||
| /// The volume of a soundboard sound must be between 0 and 1 inclusive. |
Comment on lines
+25
to
+26
| /// The data URI of the mp3 or ogg sound data, base64 encoded, similar to image data | ||
| sound: &'a str, |
Member
There was a problem hiding this comment.
Outside of the scope of the pull request: It would be nice to validate the contents of data strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.