feat(mention)!: rename timestamp styles and add new styles - #2520
Open
lukadev-0 wants to merge 1 commit into
Open
feat(mention)!: rename timestamp styles and add new styles#2520lukadev-0 wants to merge 1 commit into
lukadev-0 wants to merge 1 commit into
Conversation
github-actions
Bot
added
c-mention
raventhyme
requested changes
Jul 11, 2026
raventhyme
left a comment
raventhyme
left a comment
Member
There was a problem hiding this comment.
Thanks for the pull request. This was a confusing one to review but I think I got it all.
The Discord docs commit for this change is: discord/discord-api-docs@8e84442
lukadev-0
force-pushed
the
new-timestamp-styles
branch
from
July 12, 2026 14:04
25eb7f8 to
472b232
Compare
raventhyme
approved these changes
Jul 12, 2026
raventhyme
enabled auto-merge (squash)
July 12, 2026 15:25
raventhyme
disabled auto-merge
July 18, 2026 13:43
Member
|
this is a breaking change, shouldn't we keep the old names for a bit as aliasses? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the existing
TimestampStyles in thetwilight-mentioncrate to better match the descriptions inside of the documentation. Also adds theShortDateMediumTime(S) andShortDateTime(s) variants.The following variants have been renamed:
LongDateTime->FullDateShortTime(F)ShortDateTime->LongDateShortTime(f)LongTime->MediumTime(T)Also adds the
non_exhaustiveattribute in order to prevent having to introduce breaking changes when Discord adds new timestamp styles.