-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add a docs option to the types and block tags #4870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of Twig. | ||
| * | ||
| * (c) Fabien Potencier | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Twig\Tests\TokenParser; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Twig\Environment; | ||
| use Twig\Loader\ArrayLoader; | ||
| use Twig\Node\BlockNode; | ||
| use Twig\Parser; | ||
| use Twig\Source; | ||
|
|
||
| class BlockTokenParserTest extends TestCase | ||
| { | ||
| public function testDocsOption(): void | ||
| { | ||
| $block = $this->parseBlock('{% block content docs="The main content" %}Hello{% endblock %}', 'content'); | ||
|
|
||
| $this->assertSame('The main content', $block->getAttribute('docs')); | ||
| } | ||
|
|
||
| public function testDocsOptionWithTheShortcutSyntax(): void | ||
| { | ||
| $block = $this->parseBlock('{% block title docs="The page title" name %}', 'title'); | ||
|
|
||
| $this->assertSame('The page title', $block->getAttribute('docs')); | ||
| } | ||
|
|
||
| public function testDocsDefaultsToNull(): void | ||
| { | ||
| $block = $this->parseBlock('{% block content %}Hello{% endblock %}', 'content'); | ||
|
|
||
| $this->assertNull($block->getAttribute('docs')); | ||
| } | ||
|
|
||
| public function testShortcutSyntaxWithAVariableNamedDocs(): void | ||
| { | ||
| $twig = new Environment(new ArrayLoader(['index' => '{% block title docs %}'])); | ||
|
|
||
| $this->assertSame('Hello', $twig->render('index', ['docs' => 'Hello'])); | ||
| } | ||
|
|
||
| private function parseBlock(string $template, string $name): BlockNode | ||
| { | ||
| $env = new Environment(new ArrayLoader(), ['cache' => false, 'autoescape' => false]); | ||
| $stream = $env->tokenize(new Source($template, '')); | ||
| $parser = new Parser($env); | ||
|
|
||
| return $parser->parse($stream)->getNode('blocks')->getNode($name)->getNode('0'); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 Info — Duplicated, divergent option parsing across two tags raises future maintenance cost.
The
docsoption is parsed differently in the two tags:BlockTokenParserusestest()+look()and silently falls back to the shortcut body whendocsis not followed by=, whileTypesTokenParserusesnextIf()+expect()and raisesThe "docs" option must be followed by an equal sign (=). The divergent block behavior is required to preserve the{% block title docs %}shortcut, but the two implementations duplicate the option-detection logic with different error semantics, so a future change to the option (e.g. renamingdocstodesc) must be made in two places kept manually in sync.