Skip to content

Allow usage of other Markdown converters than CommonMark in LeagueMarkdown - #4653

Merged
fabpot merged 1 commit into
twigphp:3.xfrom
xJuvi:patch-1
Aug 2, 2025
Merged

Allow usage of other Markdown converters than CommonMark in LeagueMarkdown#4653
fabpot merged 1 commit into
twigphp:3.xfrom
xJuvi:patch-1

Conversation

@xJuvi

@xJuvi xJuvi commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

Since the CommonMarkConverter from League\CommonMark doesn't allow customizing the Environment class at construct-time, this simple change allows providing an instance the parent class, so we can both inject a config to the converter AND a custom list of extensions (like CommonMarkCoreExtension) via the constructor.

This PR fixes #3581

@xJuvi

xJuvi commented Jul 3, 2025

Copy link
Copy Markdown
Contributor Author

Hey @stof and @fabpot,
the failing check isn't caused by my change - it happens before and is another bug. All other checks were successful.

The failig checks will be fixed in #4661

Can you approve this PR?

@xJuvi

xJuvi commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

Hey @fabpot
do you need any additional changes or is this ok and can be done by approval?

Kind regards
Hannes

@fabpot

fabpot commented Aug 2, 2025

Copy link
Copy Markdown
Contributor

Thank you @xJuvi.

@fabpot
fabpot merged commit e05e818 into twigphp:3.x Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

LeagueMarkdown converter is explicitly requiring CommonMarkConverter

2 participants