Merge language and scale into one Interface settings section - #24222
Conversation
Thomas asked for a single Interface section in Settings > Experience holding both preferences. Each select now carries its own label, the way the multi-control Formats section already labels its fields.
|
🚀 Preview Environment Ready! Your preview environment is available at: https://keen-females-dvd-usually.trycloudflare.com This environment will automatically shut down after 5 hours. |
There was a problem hiding this comment.
No issues found across 3 files
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Greptile SummaryThe PR consolidates language and interface-scale controls into one labeled Interface section and reorders the Experience settings sections.
Confidence Score: 4/5The localization catalog omission should be fixed before merging so the newly introduced Interface copy participates in supported locale builds. The merged layout and select labeling are structurally sound, but three new Lingui message IDs are absent from the source catalog, leaving the new copy outside the localization pipeline. Files Needing Attention: packages/twenty-front/src/pages/settings/profile/appearance/components/SettingsExperience.tsx, packages/twenty-front/src/modules/settings/experience/components/UiScalePicker.tsx Important Files Changed
Reviews (1): Last reviewed commit: "Merge language and scale into one Interf..." | Re-trigger Greptile |
| title={t`Interface`} | ||
| description={t`Select your language and adjust the size of the interface`} |
There was a problem hiding this comment.
New messages bypass locale catalogs
When Experience settings render, the new Interface heading, description, and Scale label are absent from the source locale catalog, causing Lingui to display raw English and preventing these messages from entering the normal translation workflow.
Knowledge Base Used: Frontend Localization
There was a problem hiding this comment.
Intentional: locale catalogs are never committed manually in this repo (maintainer guidance on #24209). The i18n pipeline runs lingui extract/compile and picks new messages up from source, ci-front runs extract/compile without a diff check, and new strings fall back to their English source until translated.
Generated by Claude Code
There was a problem hiding this comment.
Got it, thanks for the context. The automatic extract/compile pipeline handles new messages without manual catalog commits — makes sense. I'll stop flagging missing catalog entries as issues in this repo.
Shall I remember this as a rule: "Do not flag new i18n strings as missing from locale catalogs — in this repo, lingui extract/compile runs automatically in CI and picks up new messages without manual catalog commits"?
There was a problem hiding this comment.
✅ Standard review · no findings
High-level — Small UI-only reorganization of Settings→Experience (adds Select labels, merges Language into the Interface section); no migration, flag, or public-surface changes and low deploy risk Reviewed against the |
🔍 Visual Regression Review —
|
| Story | Verdict | Confidence | Explained by | |
|---|---|---|---|---|
| 🔴 | modules-commandmenu-commandmenu--limited-permissions |
regression | 95% | Nothing in the PR diff touches the CommandMenu component or its dependencies. |
2 item(s) to double-check (uncertain / low confidence)
| Story | Verdict | Confidence | Explained by | |
|---|---|---|---|---|
| 🟡 | pages-settings-domains-settingssubdomain--valid-subdomain |
uncertain | 65% | N/A — PR does not touch the subdomain page or settings navigation layout. |
| 🟡 | modules-settings-playground-graphqlplayground--default |
uncertain | 60% | N/A — PR does not touch the GraphQL Playground component. |
Changed stories
| Story | Diff % |
|---|---|
| modules-commandmenu-commandmenu--limited-permissions | 16% |
| pages-settings-domains-settingssubdomain--valid-subdomain | 7% |
| modules-settings-playground-graphqlplayground--default | 3% |
| pages-settings-settingsexperience--default | 0% |
View run details · advisory mode
Designer feedback: the Language and Interface scale settings belong in a single section called Interface.
Changes
Generated by Claude Code