Repository navigation
Open Settings without freezing on Windows - #11
Merged
Merged
Conversation
open_settings was a synchronous command that builds a webview window. Synchronous commands run on the main thread, and creating a window there deadlocks on Windows: the Settings window stayed white and the app froze. Closes #10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10.
open_settingswas a synchronous command that builds the Settings webview window. Synchronous commands run on the main thread, and creating a window there deadlocks on Windows (WebView2 needs that thread): white window, frozen app. Making the commandasyncruns it off the main thread, the same waystart_capturealready creates the capture overlay. The tray menu path was not affected.