Skip to content

fix build error on Ubuntu 16.04#40

Open
niosus wants to merge 1 commit into
tux3:masterfrom
niosus:ubuntu_fixes
Open

fix build error on Ubuntu 16.04#40
niosus wants to merge 1 commit into
tux3:masterfrom
niosus:ubuntu_fixes

Conversation

@niosus

@niosus niosus commented Jan 31, 2017

Copy link
Copy Markdown

There was a bunch of build errors on Ubuntu 16.04. I've fixed them, but did not test if the fixes break anything on Windows.

Short summary:

  • fix missing QtConcurrent header. It is not present on Ubuntu.
  • fix c++11 configuration not being read
  • fix vector access. No takeAt method available. Replaced with generic at method. In case you don't need to check the boundaries, one can replace it with [index].

Comment thread widget.cpp
#include <QPainter>
#include <QRgb>
#include <QtConcurrent/QtConcurrent>
#include <QtConcurrentRun>

@tux3 tux3 Feb 15, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't build for me using a freshly downloaded Qt 5.8 SDK on Linux, I have that header in QtConcurrent/QtConcurrentRun instead
What version of Qt are you compiling with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants