This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add request object to callback for errors - #141
Open
TiMESPLiNTER wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@tuupola should I change the order of arguments so we can already use it in a 3.x release without breaking anything? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it's useful or required to have information of the request available to form a proper response.
For example the
Acceptheader of the request is required to decide in which format the response should be generated.This would be a BC break. So maybe not for 3.x but for 4.x...
If we want to omit a BC we can just change the order of the args for the error callback and append the request to the end of the arguments. That way existing closures/callbacks would still work.