fix(dep): lxml version to support proper path parsing - #44
Merged
Conversation
…etree::parse accepting a path-like object
tuunit
changed the title
tuunit
approved these changes
Nov 16, 2025
Owner
|
Thanks for contributing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump lxml dependency to >=4.8.0 for the relied-upon support of lxml::etree::parse accepting a path-like object.
In mkdocs-drawio source code, in
plugin.pyline 107, lxml::etree::parse function is called with a path-like object (specifically I had it be called with PosixPath).parse's support of accepting such an object and not just a string was only added in lxml version 4.8.0 (see line 581 here https://github.com/lxml/lxml/blob/master/CHANGES.txt).Therefore, my PR bumps the dependency, as well of updating
pyproject.tomltowards the release of version 1.12.1, as instructed in the README.Thank you!