Add doc-trim + grill-me + human-response, drop full-code-review#18
Merged
Conversation
fedesapuppo
force-pushed
the
add-doc-trim-grill-me-drop-full-review
branch
from
May 12, 2026 18:38
d67d820 to
29eaf74
Compare
fedesapuppo
changed the title
fedesapuppo
force-pushed
the
add-doc-trim-grill-me-drop-full-review
branch
2 times, most recently
from
May 12, 2026 19:02
f9d6a0b to
15a24c4
Compare
fedesapuppo
changed the title
doc-trim: editorial pass for technical docs (integration writeups, ADRs, investigation notes). Six tagged cut rules (meta, restates-obvious, justification-chain, wrapper-boilerplate, duplicate-section, prelude-padding). Proposes a unified diff with per-cut rationale and waits for approval before writing. grill-me: relentless plan/design interview that walks the decision tree one question at a time. Sourced verbatim from https://github.com/mattpocock/skills/blob/main/skills/productivity/grill-me/SKILL.md. human-response: warm, human-to-human reply drafting for handoffs, status updates, testing notes, sign-off requests. Three shapes (sign-off, testing notes, per-item status reply) plus hard rules (no bold, no em-dashes, quote UI labels exactly, hedge optional verification, address by name). Drop full-code-review: the recent task-implement slim already retired it from the workflow; its gaps versus the staff reviewer (multi-tenant scoping, authorization, N+1) now live in the pattern library (SEC-03, PERF-01). Keeping the skill file around invites accidental invocation outside the workflow. railspilot-staff-review is the single deep-review entry point.
fedesapuppo
force-pushed
the
add-doc-trim-grill-me-drop-full-review
branch
from
May 12, 2026 19:07
15a24c4 to
c64993e
Compare
tute
approved these changes
May 21, 2026
Owner
|
Gracias! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doc-trim— editorial pass for technical docs. Six tagged cut rules; proposes a unified diff with per-cut rationale and waits for approval before writing.grill-me— Matt Pocock's plan/design grilling skill, sourced verbatim from mattpocock/skills.human-response— drafts warm, human-to-human replies for handoffs, status updates, testing notes, sign-off requests. Three shapes (sign-off, testing notes, per-item status reply) plus hard rules (no bold, no em-dashes, quote UI labels exactly, hedge optional verification).full-code-review— already removed from the task-implement workflow in 93696d2; its gaps versus the staff reviewer live in the pattern library (SEC-03, PERF-01).railspilot-staff-reviewis the single deep-review entry point.