Skip to content

Updated addressFilter lib to process addresses in series. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
turntayble81 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated addressFilter lib to process addresses in series. #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7369678
Updated addressFilter lib to process addresses in series.
turntayble81 May 29, 2018
53dca02
Merge branch 'master' into feature/series-address-processing
turntayble81 May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions lib/addressFilter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function run({coordinates=[], addresses=[]}=args={}, cb) {

//Iterate over array of addresses, asyncronously calling Google's API
//for each address to determine it's lat/lng coordinates
async.each(addresses, (address, eachNext) => {
async.eachSeries(addresses, (address, eachNext) => {

googleMapsClient.geocode({address}, (err, response) => {

Expand All @@ -54,12 +54,6 @@ function run({coordinates=[], addresses=[]}=args={}, cb) {
eachNext();
});
}, (err) => {

//Because we're asyncronously calling Google's API, return order can't be
//guaranteed. As a result, let's sort the array just so it always comes out
//the same way
withinRegionArr.sort();

return cb(err, withinRegionArr);
});
}
Expand Down