[pull] master from ruby:master#1166
Merged
Merged
Conversation
MSVC builds leave dump_ast.ilk at the top of the tree, which was the only build product not already covered by .gitignore. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Same failure mode as 2bfacb5: in parallel test-all, finalizers of Tempfile objects left by other tests run on the main thread at an interrupt checkpoint while this test's trace is enabled, injecting spurious call/return events for FinalizerManager#call that the target_thread? guard cannot reject. Extract the caller_locations check into event_from_this_file? and apply it to all four trace handlers here, rejecting events whose innermost non-internal frame is not this file. The set_trace_func handler must rely on caller_locations rather than its own file argument. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
spec/mspec/lib/mspec/helpers/tmp.rb also tries to remove SPEC_TEMP_DIR at exit, before this `END`. At that time, the "tmp" marker directory causes an ENOTEMPTY.
…ed containers partial_value rebuilds the open containers on a scratch copy of the value stack. Folding an empty innermost container pops nothing and pushes its result, so head climbs one past the live size; the scratch buffer was sized to exactly the live size, so the push triggered rvalue_stack_grow which reallocated the ALLOCV buffer (a non-malloc pointer) and crashed. A parent fold always reclaims its child's slot, so head exceeds the live size by at most one -- either for the missing-value placeholder or for an empty innermost fold, never both. Size the buffer to capa + 1. ruby/json@94c1af25b5 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…et spec The TCP probe connects to the mirror URI host. connect(0.0.0.0) only behaves as loopback on Linux; on Windows it fails with an invalid address, so the example was skipped there. Probing 127.0.0.1 works on every platform. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The "is a symlink" validation warning is platform-independent, so the test only needs a working symlink rather than a blanket Windows skip. Gate it on symlink_supported? so it also runs on Windows with Developer Mode enabled. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Windows cannot express 0o600 via chmod, but the read-only bit does survive the temp-file-and-rename. Assert that bit instead of the full mode so the permission-preservation test runs on every platform. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The "maybe branch~num notation doesn't work" skip was never confirmed. main~2 ancestry refs resolve fine on current Windows git, so the example runs and passes there. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )