Disable parallel quantization for mul1 codebook#239
Open
remichu-ai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convert.py --parallel_modeis currently unsafe with--codebook mul1. In a full GLM-5.2 MUL1 quant run it corrupts layer-0 EXL3 scale metadata (.suhtensors containing NaN/Inf), which then poisons layer-1 calibration Hessians and causes Cholesky failure.This PR disables
parallel_modeautomatically when the selected codebook ismul1, with a warning, while leaving the existing parallel path unchanged for the default MCG codebook.Validation
python -m py_compile exllamav3/conversion/convert_model.py--codebook mul1 --parallel_mode: layer 0 produced NaN/Inf.suh; layer 1 Hessians became all-NaN and Cholesky failed.Notes
This is a conservative correctness guard. It avoids the known-bad combination without changing quantization kernels or the parallel path for other codebooks.