Detailed size estimation + fix #193 (overestimating fused QKV storage)#194
Open
mratsim wants to merge 2 commits into
Open
Detailed size estimation + fix #193 (overestimating fused QKV storage)#194mratsim wants to merge 2 commits into
mratsim wants to merge 2 commits into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR does 2 things related to size:
Fix [Bug] storage_size (TP) overestimates allocation of fused linear layers like QKV / QKVZ #193, for fused QKV layers, when
key_q,key_k,key_vare not set, self.key is undefined and storage will used the FP16 formula here:exllamav3/exllamav3/modules/linear.py
Lines 430 to 463 in cb1a436
This can be fixed simply by setting those keys at the model architecture level.
This expands
model.pywithget_detailed_weights_infothat is then used bysize_estimation.pyfor detailed statistics.I noticed 2 things: