Skip to content

fix(ci): собрать @delivery/shared и Prisma-клиент перед проверкой типов - #3

Merged
tulubyev merged 1 commit into
mainfrom
fix/ci-typecheck
Oct 9, 2026
Merged

tulubyev merged 1 commit into
mainfrom
fix/ci-typecheck

Conversation

@tulubyev

@tulubyev tulubyev commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

CI падал с ~60 ошибками TypeScript, но код в порядке: job ставит зависимости с --ignore-scripts, поэтому

  • не запускается prisma generate → «нет PrismaClient, OrderStatus, AlertType…»;
  • не собирается пакет @delivery/shared (его types указывают на dist/) → «Cannot find module '@delivery/shared'»;
  • всё остальное (implicit any в колбэках) — следствие этих двух.

Добавлены два шага перед tsc. Локально на чистом клоне: API — 0 ошибок, Web — 0 ошибок.

⚠️ После merge в main CI станет зелёным, и каждый push в main снова будет запускать сборку Docker-образов → деплой на VPS (secrets.VPS_HOST) → EAS-сборку Android APK. Проект на паузе — перед merge проверь, что секрет VPS_HOST указывает на 90.156.168.149, или мержи с [skip ci].

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated automated deployment checks to prepare required project components before running type checks.
    • No user-facing changes.

…e-check

The check job installs with --ignore-scripts, so Prisma's postinstall never
runs and nothing builds the workspace package. tsc then can't find
PrismaClient, the Prisma enums or @delivery/shared, and every downstream
callback becomes implicit any. With both steps the API and Web type-check
clean (0 errors locally).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e051268c-cad7-4b2c-b151-0bcfee829c9b
📥 Commits

Reviewing files that changed from the base of the PR and between 7f26bcf and 5ab3244.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The deploy workflow now builds @delivery/shared and generates the Prisma client before it runs TypeScript checks.

Changes

Deploy type-check setup

Layer / File(s) Summary
Prepare type-check dependencies
.github/workflows/deploy.yml
The check job builds @delivery/shared and generates the Prisma client before TypeScript checks.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 5ab32

The workflow prepares the shared package and Prisma client before type-checking. No actionable merge-blocking issue was identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main CI change: building @delivery/shared and generating the Prisma client before type checking.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tulubyev
tulubyev merged commit fc86219 into main Oct 9, 2026
5 checks passed
@tulubyev
tulubyev deleted the fix/ci-typecheck branch October 9, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant