Phase 0-2: 設定ファイルの矛盾解消と不要ファイルの追跡解除 - #70
Merged
Merged
Conversation
- playwright.config.ts: baseURL/webServer.url のポートを 8080 → 実際の開発サーバーポート 3000 に統一(PORT 既定値に整合) - .serena/: 外部AIツール(Serena)のローカル設定を git 追跡から外し .gitignore に追加(ローカルファイルは保持) - .github/workflows/test.yml: backend-tests の `|| echo "Backend tests not yet configured"` を削除。 バックエンドテスト154件は確立済みで、失敗の握りつぶしは危険 - jest.config.ts / codecov.yml: 暫定的なカバレッジ閾値であり Phase 5 で実測ベースに引き上げる旨のコメントを追加(数値は据え置き) 全366テスト green を確認。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
リファクタリング計画 Phase 0(リポジトリ衛生)の作業項目 0-2 です。設定・CI・リポジトリ衛生のみの変更で、アプリの挙動には影響しません。
変更内容
playwright.config.tsbaseURL/webServer.urlを8080→3000server/src/index.tsのPORT既定値 3000)と不一致だった.serena/.gitignore追加.github/workflows/test.yml|| echo "Backend tests not yet configured"を削除jest.config.ts/codecov.yml確認
codecov.yml/test.ymlの YAML 構文が valid であることを確認git ls-files | grep .serenaが空補足
codecov.ymlのthreshold: 1%は「許容低下幅 1%」(target: autoでベースとの相対比較)であり、当初の調査が示唆した「目標 1%」という形骸化ではありませんでした。そのため codecov 側の数値は据え置き、コメント追記のみとしています。🤖 Generated with Claude Code