fix: skip related plannings query when there are no events#2687
Open
dannelundqvist wants to merge 1 commit into
Open
fix: skip related plannings query when there are no events#2687dannelundqvist wants to merge 1 commit into
dannelundqvist wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The Event / Events overview list annotates events with related plannings via
withPlannings, which builds atermsquery ondocument.rel.event.uuidfrom the event ids. On dates with no events the id array is empty, and an emptyterms.valuesis dropped on serialization, so the index receives atermsclause with novaluesand answers with a 500. This is why some dates (no events) consistently fail while dates with events load fine.Fix
Guard against empty event ids in
withPlanningsand skip the query when there are none (no events means there are no related plannings to look up). Adds a regression test covering the empty case and the normal case.Note: it would also be good for the index query endpoint to answer 400 rather than 500 on a malformed
termsclause, but that is a separate elephant-index change.