fix: uninstall stands the daemon down via the disable flag#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vigil uninstallstopped the daemon with a barepkill, which orphaned the caffeinate child (no signal handler, so no cleanup) holding the display awake up to its 30-minute-tcap. It now writes the.disabledsentinel, which the daemon notices reactively through its runtime-dir watch and clean-exits, killing its caffeinate on the way out.pkillsurvives only as a fallback for a daemon too wedged to see the flag within three poll intervals.docs/ANALYSIS.md(the 2026-07-14 code-review findings) with the three addressed entries already removed and AN-004 updated for what shipped today.Test plan
cargo fmt --check,clippy -D warnings,cargo test(30 tests) green locally