fix: bound logged commands and update README for turn-span#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commandfield to 1 KiB at record time (AN-001). It was the one unbounded hook field, and a line longer than the 8 KiB tail window is unreadable byread_last_line, which made the session invisible to the daemon and released the hold mid-turn, exactly the failure class turn-span was built to remove. Nothing readscommandsince commit detection was deleted, so the bound only trims what future reactors would see.statusnow shows the daemon's last decision.Test plan
cargo fmt --check,clippy -D warnings,cargo test(30 tests, including truncation char-boundary cases and a worst-case-escaping line-size guarantee) green locallyvigil recordpath produced a 1188-byte line that parses, command bounded at 1024 bytes plus ellipsis