Fix short schematic trace routing#638
Open
mohan-bee wants to merge 19 commits into
Open
Conversation
overlapping component pins
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
requested changes
Jul 8, 2026
seveibar
reviewed
Jul 8, 2026
seveibar
left a comment
Contributor
There was a problem hiding this comment.
Can you moce this logic inside the schematic trace solver? Algorithms dont belong in core- it makes it hard to send reproductions to the algo repo
Contributor
Author
inductor is placed manually,, but if feel like having a four unnecessary netlabels that is making a complete mess... , actually schematic-trace-solver is not handling the short distance connection, it fall backs to netlabel, why when two components placed so close having netlabel is won't be good ig, |
seveibar
requested changes
Jul 9, 2026
seveibar
left a comment
Contributor
There was a problem hiding this comment.
- Dont clutter classes with instance methods that dont need to be instance methods (no state or primarily not state mutating)
- Proof that this works? I dont see it in the snapshot working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very short schematic connections between nearby pins could route with unnecessary elbow overshoot, or fail entirely when one endpoint sat slightly inside a neighboring component's obstacle — causing a fallback net label to appear instead of a short trace.
Change
Add a short-distance path case in SchematicTraceSingleLineSolver2, checked before elbow routing (gated by MAX_SHORT_TRACE_DISTANCE).
Normal-distance traces are unaffected — they still go through the existing elbow/collision search path.
BEFORE:
AFTER: