Restore test pattern for framebuffer debugging#27
Conversation
This restores the previously removed fb_test_pattern function in kernel/fb.in, which is a ~3KB pixel-loop used for manual display bring-up debugging. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- PR #23: heap allocator with free list + heap_free; sys_chan_close reclaims - PR #11: free printf_padded temp buffer; wire libc free() to heap_free - PR #13: split libc_selftest into category helpers - PR #12/#19/#24: strncpy edge cases and expanded strlen coverage - PR #27: restore fb_test_pattern via fb_fill_rect; shell `fb test` command - Update context.md ponytail index
|
Changes applied directly on main in c654a13. |
|
Merged to main in c654a13. |
1 participant
This change restores the
fb_test_patternfunction inkernel/fb.inwhich was previously removed. The pattern is intended for manual pixel-level display bring-up verification by painting colored stripes onto the framebuffer and performing sanity readbacks.I verified the changes using
git diff --cached --checkas we don't have the external compiler locally to run tests and the code is intended for debug only, as noted by the memory instructions. Code review was also requested and passed.PR created automatically by Jules for task 1882186555338202440 started by @undivisible