kernel: Use constants instead of magic numbers in fs_init#16
kernel: Use constants instead of magic numbers in fs_init#16undivisible wants to merge 1 commit into
Conversation
Replaces the hardcoded `2048` magic number in `fs_init` with the equivalent constant expression `FS_MAX_FILES * FS_ENTRY_SIZE` now that const folding for global constants is supported by the toolchain. Removes the associated "ponytail" comment mentioning the previous compiler limitation. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Fix stray brace in kernel-root.in and remove dead thr_exit return - Add heap/obj_arena bounds checks (PRs #30, #26) - Harden malloc/calloc/realloc; replace strcpy with strlcpy; remove strcat (PRs #20, #18, #21, #28, #15) - Split nvme_pci_init, restore e1000_rx_poll, use FS_MAX_FILES constants (PRs #14, #17, #16) - Refresh context.md ponytail index after service-wrapper deletion
|
Changes applied directly on main (rebased past shell.in extraction and service-wrapper deletion). Used panic() instead of unreachable()/assert() where the PRs referenced undefined helpers. |
|
Merged to main in 22933b8. Changes applied directly on main (rebased past shell.in extraction and service-wrapper deletion). Used panic() instead of unreachable()/assert() where the PRs referenced undefined helpers. |
1 participant
Replaces the hardcoded
2048magic number infs_initwith the equivalent constant expressionFS_MAX_FILES * FS_ENTRY_SIZEnow that const folding for global constants is supported by the toolchain. Removes the associated "ponytail" comment mentioning the previous compiler limitation.PR created automatically by Jules for task 18172030698577237658 started by @undivisible