Skip to content

fix(android): guard onDetachedFromEngine against null channel (NPE on headless engine teardown) #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ant1Miller wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): guard onDetachedFromEngine against null channel (NPE on headless engine teardown) #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion android/src/main/java/co/tryterra/terra_flutter_bridge/TerraFlutterPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,12 @@ public void onMethodCall(@NonNull MethodCall call, @NonNull Result result) {

@Override
public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) {
channel.setMethodCallHandler(null);
// channel is created in onAttachedToActivity, so a headless engine that never
// attaches an Activity (e.g. an FCM background isolate) reaches here with it null.
if (channel != null) {
channel.setMethodCallHandler(null);
channel = null;
}
}

}