feat: Implement extend from slice on SoAVec - #38
Merged
Conversation
Collaborator
Author
|
Unsure about the runtime here if its |
Member
The tuple is (using the derive macro, and under any reasonable custom implementation) determined by the number of fields in the original struct. |
aapoalas
approved these changes
Oct 6, 2025
aapoalas
left a comment
Member
There was a problem hiding this comment.
LGTM, and praise for a nice set of tests as well! <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extend_from_slicefor SoAVecuses T::TupleReps::write to write each element from slice into self.buf and then update length.
Closes #25