feat: add SoAVec::swap_remove - #36
Merged
Merged
Conversation
omfj
force-pushed
the
add-swap-remove
branch
from
September 30, 2025 11:47
47af6f6 to
745973a
Compare
omfj
marked this pull request as ready for review
September 30, 2025 11:55
aapoalas
reviewed
Oct 6, 2025
aapoalas
requested changes
Oct 6, 2025
aapoalas
left a comment
aapoalas
left a comment
Member
There was a problem hiding this comment.
Some changes needed. I think the index/length checking is off-by-one, and it turns out we can simplify the error case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23