fix: rename len to __soa_len to avoid field name conflicts - #32
Merged
Conversation
omfj
force-pushed
the
26-len-field-name-breaks-soable-derive-macro
branch
from
September 23, 2025 10:03
16af208 to
3508add
Compare
Member
|
LGTM <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The argument
lencould be overwritten by a field namedlen.Solution
Rename the argument
lento__soa_lenbefore unpacking the fields. We can also prohibit the use of a field named__soa_lento avoid__soa_lenalso being overwritten, but I don't believe this is a very common name for a field.Closes #26