Skip to content

feat: add insert api - #31

Merged
aapoalas merged 3 commits into
mainfrom
add-insert-api
Sep 30, 2025
Merged

feat: add insert api#31
aapoalas merged 3 commits into
mainfrom
add-insert-api

Conversation

@omfj

@omfj omfj commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

Closes #21

Comment thread soavec/src/lib.rs Outdated
Comment thread soavec/src/lib.rs Outdated
@omfj

omfj commented Sep 23, 2025

Copy link
Copy Markdown
Collaborator Author

@aapoalas Should the SoAVec::insert and SoAVec::insert_mut return Result with AllocError?

Nevermind, seems you have already commented on this. Hadn't refreshed my GitHub hehe :)

@omfj
omfj force-pushed the add-insert-api branch 4 times, most recently from d63bd2e to 2f07f8e Compare September 23, 2025 06:19
@omfj
omfj marked this pull request as ready for review September 23, 2025 06:19
@omfj
omfj force-pushed the add-insert-api branch 2 times, most recently from b99248e to 6e63e77 Compare September 23, 2025 09:33
Comment thread soavec/src/lib.rs Outdated
@omfj
omfj force-pushed the add-insert-api branch 2 times, most recently from b0d78eb to da98fb9 Compare September 28, 2025 08:17

@aapoalas aapoalas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! <3

@aapoalas
aapoalas merged commit e549451 into main Sep 30, 2025
3 checks passed
@aapoalas
aapoalas deleted the add-insert-api branch September 30, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

insert API

2 participants