ci: run anti-slop lint in CI and pre-push (CMP-84) - #153
Merged
Conversation
The rules went to zero in one pass, but nothing kept them there. A single Record<string, unknown> merged tomorrow puts the count back to one, and the next one hides in the noise. lint:slop joins check-types, lint and test in CI and in the pre-push hook, so a boundary that stops being parsed fails on the machine that wrote it rather than in review. The plugin is loaded as an ES module from a directory with no type field, which made node reparse it and warn about the cost on every run. tools is not a workspace, so a package.json there scopes the declaration to the plugin without touching the root.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
ripgrim
changed the title
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened automatically when
rg/gate-anti-slop-ciwas pushed.The title is written from the diff and rewritten as you push, because this is squashed onto
mainand the title becomes the commit subject and the changelog line. Retitle it yourself and it is yours — the automation stops touching it.Summary by cubic
Runs
lint:slopin CI and the pre-push hook to enforce boundary parsing rules, so regressions fail locally and in CI. Previously CI/pre-push ran onlycheck-types,lint, andtest, and the anti-slop plugin triggered a Node reparse warning; now the plugin loads as ESM and the warning is gone. Addresses CMP-84.Review notes
bun run lint:slopalongsidecheck-types,lint, andtest;CONTRIBUTING.mddocuments the rule and how to fix violations.tools/oxlint/anti-slop/package.jsonwith"type": "module"to load the plugin as ESM and remove Node reparse warnings.Rollout
bun installto install thepre-pushhook.lint:slopfails: define schemas inpackages/validation/srcand parse data at the I/O boundary; only exempt genuine open maps in.oxlintrc.jsonwith a reason.Written for commit ca4f590. Summary will update on new commits.