Skip to content

DOCS-2704 / 27 / checkout resilience against concurrent-DNS-flake (master) - #4762

Merged
tonyriv3 merged 1 commit into
masterfrom
DOCS-2704-checkout-resilience-master
Sep 2, 2026
Merged

DOCS-2704 / 27 / checkout resilience against concurrent-DNS-flake (master)#4762
tonyriv3 merged 1 commit into
masterfrom
DOCS-2704-checkout-resilience-master

Conversation

@DjP-iX

@DjP-iX DjP-iX commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Same change already smoke-tested and confirmed working on 25.10 (#4761, build #19 SUCCESS — lock acquired/released cleanly, checkout+commit metadata correct, pipeline completed through Symlink).

Root-caused an incident from the DOCS-2704 cleanup: merging cleanup PRs to several branches within minutes of each other caused Docs Versioned Sites to trigger concurrent builds, and simultaneous SCM checkouts on the shared docbuilds02 agent intermittently failed with Could not resolve host: github.com. Confirmed empirically — 3 branches triggered simultaneously gave mixed pass/fail on the same node; every branch went green when retried one at a time.

skipDefaultCheckout() + explicit Checkout stage, serialized via lock('docs-checkout'), narrow retry (3 attempts, 10s backoff) only on the diagnosed DNS-failure signature, timeout(5m) to bound worst-case queuing.

…DOCS-2704)

Same change smoke-tested and confirmed working on 25.10 (PR #4761, build #19
SUCCESS): skipDefaultCheckout() + an explicit Checkout stage serialized via
lock('docs-checkout') (mirrors the existing docs1-deploy lock pattern), with
a narrow retry (max 3 attempts, 10s backoff) that fires only on the diagnosed
'Could not resolve host: github.com' signature — any other exception fails
immediately so a real problem isn't masked. timeout(5m) bounds worst-case
queuing latency if many branches trigger together.
@DjP-iX
DjP-iX requested a review from a team as a code owner September 2, 2026 18:55
@bugclerk bugclerk changed the title DOCS-2704: checkout resilience against concurrent-DNS-flake (master) DOCS-2704 / 27 / checkout resilience against concurrent-DNS-flake (master) Sep 2, 2026
@bugclerk

bugclerk commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@tonyriv3 tonyriv3 added the Technical Writer Review (TR) A technical writer is reviewing the PR. label Sep 2, 2026
@tonyriv3
tonyriv3 merged commit ec3fdb2 into master Sep 2, 2026
4 checks passed
@tonyriv3
tonyriv3 deleted the DOCS-2704-checkout-resilience-master branch September 2, 2026 19:52
@bugclerk

bugclerk commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-time-tracked Technical Writer Review (TR) A technical writer is reviewing the PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants