Skip to content

Improved In-App updater for .deb installs #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
truelockmc merged 3 commits into from
May 19, 2026
Merged

Improved In-App updater for .deb installs #85

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9fce95
In-App updater now properly updates .pacman installs
truelockmc May 18, 2026
82b477f
.deb in-app update now restarts after installing
truelockmc May 19, 2026
cec52c8
Merge branch 'main' into dev-latest
truelockmc May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 33 additions & 13 deletions src/ipc/player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,19 @@ function register(getMainWindow, { writeSecretMigration }) {

if (signal.aborted) return { ok: false, error: "Cancelled" };

// ── Helper: send "Installing…" to renderer ──────────────────────────────
const sendInstalling = () => {
const mw = getMainWindow();
if (mw && !mw.isDestroyed()) {
mw.webContents.send("update-progress", {
percent: 100,
label: "Installing…",
});
}
};

if (format === "appimage") {
sendInstalling();
fs.chmodSync(destPath, 0o755);
const currentAppImage = process.env.APPIMAGE;
if (currentAppImage) {
Expand All @@ -323,15 +335,11 @@ function register(getMainWindow, { writeSecretMigration }) {
writeSecretMigration();
app.exit(0);
} else if (format === "pacman") {
sendInstalling();
// Give the renderer a moment to process the IPC message and show
// "Installing…" before spawnSync blocks the main thread
await new Promise((r) => setTimeout(r, 150));
fs.chmodSync(destPath, 0o644);
// notify renderer
const mwPac = getMainWindow();
if (mwPac && !mwPac.isDestroyed()) {
mwPac.webContents.send("update-progress", {
percent: 100,
label: "Installing…",
});
}
const pacmanLaunchers = [
{ bin: "pkexec", args: ["pacman", "-U", "--noconfirm", destPath] },
{ bin: "pamac-installer", args: [destPath] },
Expand Down Expand Up @@ -359,6 +367,8 @@ function register(getMainWindow, { writeSecretMigration }) {
shell.openPath(destPath);
}
} else if (format === "deb") {
sendInstalling();
await new Promise((r) => setTimeout(r, 150));
fs.chmodSync(destPath, 0o644);
const debLaunchers = [
{ bin: "pkexec", args: ["dpkg", "-i", destPath] },
Expand All @@ -375,19 +385,29 @@ function register(getMainWindow, { writeSecretMigration }) {
{ encoding: "utf8" },
);
if (which.status !== 0) continue;
spawn(bin, args, { detached: true, stdio: "ignore" }).unref();
launched = true;
break;
// spawnSync, to wait for dpkg to finish before relaunching
const result = spawnSync(bin, args, { stdio: "inherit" });
if (result.status === 0) {
launched = true;
break;
}
} catch {
continue;
}
}
if (!launched) shell.openPath(destPath);
if (launched) {
writeSecretMigration();
app.relaunch();
app.exit(0);
} else {
shell.openPath(destPath);
}
} else if (format === "exe") {
sendInstalling();
spawn(destPath, [], { detached: true, stdio: "ignore" }).unref();
app.exit(0);
} else if (format === "dmg" || format === "dmg_arm64") {
// Mount the DMG and open it
sendInstalling();
spawn("hdiutil", ["attach", destPath], {
detached: true,
stdio: "ignore",
Expand Down
Loading