windows: add targeted UIA lookup and fix MCP schemas#3
Merged
Conversation
…utomation-integration
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Collaborator
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a targeted
find_elementMCP tool for locating UIA elements by query, label, automation id, identifier, control type, and browser/page search zones.Improves Windows action routing by preferring supported UIA action patterns before MSAA fallback, treating UIA
linkcontrols as actionable, and keeping the named-pipe daemon alive when clients disconnect during slow requests.Makes MCP array schemas declare
itemsand adds schema coverage for OpenAI-compatible tool definitions.Updates the Windows build helper to honor
global.jsonSDK roll-forward by accepting the SDK thatdotnetresolves from the repo root.Related Issue
Closes #2
Area
Safety Contract
background_safe,cursor_moved, andforeground_changed.Validation
dotnet build trope-cua.slnscripts\run-tests.ps1cd native/macos/trope-cua && swift buildcd native/macos/trope-cua && ./scripts/test.shgit diff --checkEvidence
scripts\run-tests.ps1: 78 passed in 30.54s after the SDK roll-forward helper fix.git diff --check: passed.Risks and Follow-Up
An earlier local full-suite run had one cursor-position mismatch in
test_visual_move_cursor_does_not_move_real_cursor; the isolated test passed immediately afterward and subsequent full-suite runs passed. macOS validation was not run locally because this PR changes the Windows driver/MCP/build-script path only; GitHub macOS CI passed on the first PR run.