fix(github): migrate production OAuth to the organization BFF - #5
Closed
Redchar1992 wants to merge 2 commits into
Closed
fix(github): migrate production OAuth to the organization BFF#5Redchar1992 wants to merge 2 commits into
Redchar1992 wants to merge 2 commits into
Conversation
- move state, PKCE, identity verification, encrypted tokens, REST, and Git auth server-side\n- replace browser token storage with short-lived origin-bound sessions and fail-closed cutover\n- add Deno, frontend, browser, CI, and migration coverage
- Remove personal Deno and callback fallbacks from frontend and BFF configuration.\n- Fail deployments closed until the organization BFF origin is configured.\n- Align migration guidance and regression coverage with the online cutover.
Collaborator
Author
|
Closing this PR because the OAuth BFF changes will be reapplied on release/v2.3.3 and included in the v2.3.3 test submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt=select_accountRequired before merge / production cutover
tronweb3GitHub OAuth App and Deno project from the agreed setup documents.services/github-oauth/main.tswith Deno KV and these environment variables:GITHUB_CLIENT_IDGITHUB_CLIENT_SECRETSESSION_ENCRYPTION_KEYREDIRECT_URIALLOWED_ORIGINS=https://test.tronide.allsandlab.com,https://tronide.ioTRONIDE_GITHUB_BFF_ORIGINto the organization-owned Deno origin. The Pages workflow intentionally fails before build if it is missing or is not HTTPS.<TRONIDE_GITHUB_BFF_ORIGIN>/callback.Validation
pnpm dlx deno@2.4.2 task checkpnpm dlx deno@2.4.2 task test— 9 passedKnown baseline limitation
apps/remix-ide/test/remix-220-home-parity-test.jsreaches and passes the changed OAuth assertions, then fails on a traceability Markdown file that is already referenced but absent onmain. This PR does not introduce that unrelated baseline issue.A live OAuth authorization cannot be completed until the organization OAuth App and Deno environment are available; perform the test/production account, Gist, private repository, push/pull, disconnect, and expiry checks during cutover.
CI status after opening the PR
GitHub OAuth BFF checks: passedBuild: passedPlaywright smoke: skipped by the existing pull-request trigger policyLint: stopped inpnpm audit --prodbecause the currentmaindependency graph contains 7 newly reported advisories (brace-expansion,mermaid, anddompurify). This PR changes no package manifest or lockfile, and the targeted ESLint checks for all changed frontend files pass locally.The existing Pages workflow runs only after a push to
main(or a manual dispatch), so this pull request does not deploy the online site before merge.