Skip to content

fix(github): always prompt users to select an account #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Redchar1992 wants to merge 1 commit into from
Closed

fix(github): always prompt users to select an account #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/remix-ide/src/lib/github-oauth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ export function connectWithGithubOAuth (opts = {}) {
redirect_uri: GITHUB_OAUTH.redirectUri,
scope: opts.scope || GITHUB_OAUTH.scope,
state,
allow_signup: 'false'
allow_signup: 'false',
// Avoid silently reusing whichever GitHub account is active in the
// browser, especially on shared devices or with multiple sessions.
prompt: 'select_account'
}).toString()

const w = 720
Expand Down
1 change: 1 addition & 0 deletions apps/remix-ide/test/audit-20260721-remediation-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ test('URL imports, wallet events, OAuth messages, and AI staging keep their secu
t.ok(filePanel.indexOf('normalizeUrlImport(params.url)') !== -1, '#url is allow-listed before contentImport.resolve')
t.ok(wallet.indexOf('event.source !== window || event.origin !== window.location.origin') !== -1, 'wallet postMessage requires the same window and origin')
t.ok(oauth.indexOf('event.source !== popup') !== -1, 'OAuth completion must come from the popup that was opened')
t.ok(oauth.indexOf("prompt: 'select_account'") !== -1, 'OAuth must let users choose the GitHub account explicitly')
t.ok(chat.indexOf("title: 'AI wants to stage all workspace changes'") !== -1, 'git_stage_all asks for confirmation')
t.ok(chat.indexOf("title: 'AI wants to stage workspace files'") !== -1, 'git_stage asks for confirmation')
t.end()
Expand Down
Loading