Skip to content

Fix typo: _aync_engine_args -> _async_engine_args #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahi-mullapudi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo: _aync_engine_args -> _async_engine_args #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def initialize(self, args):
# TODO: Move the check into _setup_metrics().
self._enable_metrics = (
self._get_bool_config_param("REPORT_CUSTOM_METRICS")
and not self._aync_engine_args.disable_log_stats
and not self._async_engine_args.disable_log_stats
)

# Setup vLLM metrics
Expand Down Expand Up @@ -225,7 +225,7 @@ def _init_engine_args(self):
self._setup_lora()

# Create an AsyncEngineArgs from the config from JSON
self._aync_engine_args = AsyncEngineArgs(**self.vllm_engine_config)
self._async_engine_args = AsyncEngineArgs(**self.vllm_engine_config)

def _init_engine(self):
# Run the engine in a separate thread running the AsyncIO event loop.
Expand Down Expand Up @@ -266,7 +266,7 @@ async def _run_llm_engine(self):
# statement.
# TODO: Metrics should work with ZMQ enabled.
async with build_async_engine_client_from_engine_args(
engine_args=self._aync_engine_args,
engine_args=self._async_engine_args,
logger=self.logger,
disable_frontend_multiprocessing=self._enable_metrics,
stat_loggers=self._vllm_metrics,
Expand Down