test: Add Python custom metrics reload regression - #8892
Draft
goanpeca wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Python backend QA coverage for custom histogram metrics across model reloads. The new
custom_metrics_reloadmodel creates the same persistent histogram metric from three Python backend instances, then the test sends inference requests, touchesmodel.py, reloads the model through explicit model control, and sends more requests to catch the stale shared metric crash path from issue #8663.Linked issue
Relates to #8663
Tests run
mamba run -n server-issue-8663 python -m py_compile qa/python_models/custom_metrics_reload/model.py qa/L0_backend_python/custom_metrics/custom_metrics_reload_test.py qa/python_models/custom_metrics/model.pybash -n qa/L0_backend_python/custom_metrics/test.shFull
qa/L0_backend_python/custom_metrics/test.shwas not run locally because this checkout does not include a builttritonserverbinary or Python backend artifacts.Follow-up notes
The underlying MetricStorage lifecycle implementation is tracked in triton-inference-server/core#471; this PR adds server QA coverage for the Python backend reload scenario.