Skip to content

fix(openai-frontend): use hmac.compare_digest for restriction header value #8788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibondarenko1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(openai-frontend): use hmac.compare_digest for restriction header value #8788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions python/openai/openai_frontend/frontend/fastapi/middleware/api_restriction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

import hmac

from fastapi import Request
from fastapi.responses import JSONResponse
from starlette.middleware.base import BaseHTTPMiddleware
Expand Down Expand Up @@ -219,8 +221,11 @@ def _check_authentication(self, request: Request, auth_header: tuple[str, str]):
# Get the actual header value from the request
actual_value = request.headers.get(expected_key)

# Validate the header value matches the expected value
if not actual_value or actual_value != expected_value:
# Validate the header value matches the expected value. Use
# hmac.compare_digest so the compare runs in time that does not
# depend on the position of the first differing byte. The short
# circuit on `not actual_value` keeps None and empty values out.
if not actual_value or not hmac.compare_digest(actual_value, expected_value):
return {
"valid": False,
"message": f"This API is restricted, expecting header '{expected_key}' with valid value",
Expand Down