fix: Properly mount paths for L0_custom_ops's Docker sub-test - #987
Merged
Conversation
The test was failing in CI due to Docker-in-Docker volume mount issues. When Model Analyzer runs in a CI container and launches Triton in Docker mode, the Docker daemon (running on the host) cannot access paths that only exist inside the CI container. Root cause: The path /mnt/nvdl/datasets/inferenceserver/ exists inside the CI container but not on the host where Docker daemon runs. When Docker tries to mount this path, it fails with "read-only file system". Solution: Use /tmp/output/ for Docker mode, following the pattern from L0_server_launch_modes test. This path is accessible to both the CI container and the Docker daemon on the host. Changes: - Copy models to /tmp/output/L0_custom_ops_models for Docker mode - Keep /tmp/L0_custom_ops_models for c_api and local modes - Update test_config_generator.py to handle both paths correctly - Docker mode mounts /tmp/output path which the daemon can access - c_api/local modes use local /tmp path with LD_PRELOAD This ensures all three modes (c_api, local, docker) work in CI without any mode-specific branching or skipping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was failing in CI due to Docker-in-Docker volume mount issues. When Model Analyzer runs in a CI container and launches Triton in Docker mode, the Docker daemon (running on the host) cannot access paths that only exist inside the CI container.
Root cause: The path /mnt/nvdl/datasets/inferenceserver/ exists inside the CI container but not on the host where Docker daemon runs. When Docker tries to mount this path, it fails with "read-only file system".
Solution: Use /tmp/output/ for Docker mode. This path is accessible to both the CI container and the Docker daemon on the host.
Changes:
This test now passes CI.