clean up: ignore test-generated artifacts - #981
Merged
Conversation
added 3 commits
November 13, 2025 11:45
The previous patterns (qa/**/*.csv) were incorrectly matching files in tests/ and experiments/ directories because gitignore ** matches across directory boundaries. By adding leading slash (/qa/**/*.csv), patterns now correctly anchor to repo root and only match files under the qa/ directory, preserving committed test fixtures in tests/common/ and experiments/data/.
lkomali
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running CI test locally, a lot of artifacts are generated that should not be checked in. Add these to .gitignore to avoid the overhead of avoiding these and risks of accidental check-in.