Skip to content

ci: enable secret-scan-trufflehog pre-commit hook - #37

Open
mc-nv wants to merge 1 commit into
mainfrom
mchornyi/TRI-1701/enable-trufflehog-pre-commit-rule
Open

ci: enable secret-scan-trufflehog pre-commit hook#37
mc-nv wants to merge 1 commit into
mainfrom
mchornyi/TRI-1701/enable-trufflehog-pre-commit-rule

Conversation

@mc-nv

@mc-nv mc-nv commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Description

Enables the NVIDIA secret-scan-trufflehog pre-commit hook, pinned to v0.3.0,
as the first entry under repos: so scanning runs before any formatter rewrites
the working tree.

This adopts the centrally maintained hook published by NVIDIA/security-workflows
rather than a hand-rolled TruffleHog invocation, so the scanner version and its
per-platform checksums are bumped in one reviewed place instead of 27.

v0.3.0 is pinned deliberately. It installs the scanner inside pre-commit's own
Python environment — removing the shell installer, so Windows works without Git
Bash — and it adds --exclude-detectors=lob. That exclusion matters here: a Lob
API key is test_ followed by 35 characters, so the detector matches ordinary
pytest function names such as test_gpu_conf_compute_attestation_report, and
Lob's verifier reports them as verified — the one result class this hook fails
on.

Behaviour: scans only the files pre-commit supplies (staged files at commit time,
the push range at push time), reports verified secrets only, and fails closed on
a finding.

Deliberately out of scope:

  • No ci: skip: block. That is prescribed for the hosted pre-commit.ci sandbox,
    which has no network access. No Triton repo uses pre-commit.ci — CI runs
    pre-commit from .github/workflows/pre-commit.yml — so it would be dead config.
  • No default_install_hook_types change. Activation is a developer action;
    changing that key would alter install behaviour for every hook in the repo,
    not just this one. Tracked separately.

Changes

  • Add NVIDIA/security-workflows secret-scan-trufflehog @ v0.3.0 as the
    first entry under repos:.

Affected Files

  • .pre-commit-config.yaml

Test plan

  • pre-commit validate-config — passes.
  • pre-commit run secret-scan-trufflehog --all-files — passes, with zero
    pre-existing verified secrets, so CI does not break on merge.
  • TruffleHog 3.95.9 confirmed installed into pre-commit's Python environment
    and executed, so the hook is functional rather than a silent no-op.
  • Blast radius is bounded: .github/workflows/pre-commit.yml runs
    pre-commit run --files against PR-modified paths only, never --all-files.

Caveats

Editing the config alone scans nothing. Each contributor must run once per clone:

pre-commit install --hook-type pre-commit
pre-commit install --hook-type pre-push

Without the second, the pre-push stage stays dormant.

Related PRs

Also part of this rollout, on internal GitLab: dl/dgx/tritonserver!1853 and dl/dgx/tritonmodelanalyzer!181.

Related Issues

  • Resolves: TRI-1701

@mc-nv mc-nv self-assigned this Aug 15, 2026
@mc-nv mc-nv added the CI/CD Continuous integration and workflow changes (ci: PRs) label Aug 15, 2026
@mc-nv
mc-nv marked this pull request as ready for review August 15, 2026 00:11
@greptile-apps

greptile-apps Bot commented Aug 15, 2026

Copy link
Copy Markdown

Greptile Summary

The PR adds the centrally maintained NVIDIA TruffleHog secret-scanning hook as the first pre-commit repository entry.

  • Pins NVIDIA/security-workflows to v0.3.0.
  • Enables the secret-scan-trufflehog hook while preserving the existing formatter and validation configuration.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable defects identified in the added pre-commit hook configuration.

The hook is pinned, placed before formatters as intended, and the documented validation and execution results address the relevant installation and runtime failure paths.

Important Files Changed

Filename Overview
.pre-commit-config.yaml Adds a pinned secret-scanning hook in the intended first position without altering existing hook settings.

Reviews (1): Last reviewed commit: "ci: enable secret-scan-trufflehog pre-co..." | Re-trigger Greptile

This was referenced Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Continuous integration and workflow changes (ci: PRs)

Development

Successfully merging this pull request may close these issues.

1 participant