ci: migrate the centralized add-license hook to the org .github repository

.pre-commit-hooks.yaml → .github/workflows/conventional-pr.yml

@@ -24,10 +24,31 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-- id: add-license
-  name: Add License
-  entry: tools/add_copyright.py
-  language: script
-  stages: [pre-commit]
-  verbose: true
-  require_serial: true
+# Thin caller: the logic lives in the org-wide reusable workflow, pinned by
+# tag. Workflow changes ship as a new tag in the .github repository plus a
+# one-line rev bump here (tags are write-once, never moved).
+
+name: conventional-pr
+
+on:
+  pull_request:
+    types: [opened, edited, synchronize, reopened]
+  pull_request_target:
+    types: [opened, edited, synchronize, reopened]
+
+jobs:
+  conventional-pr:
+    # Same-repo PRs run on the safe pull_request event; fork PRs run on
+    # pull_request_target so the labeling job gets a writable token (safe
+    # here: the reusable workflow never checks out PR code - it only reads
+    # PR metadata via the API and manages labels).
+    if: >-
+      (github.event_name == 'pull_request' &&
+       github.event.pull_request.head.repo.full_name == github.repository) ||
+      (github.event_name == 'pull_request_target' &&
+       github.event.pull_request.head.repo.full_name != github.repository)
+    permissions:
+      pull-requests: write
+      issues: write
+      contents: read
+    uses: triton-inference-server/.github/.github/workflows/conventional-pr.yml@v1.4.3

.github/workflows/pre-commit.yml

@@ -32,14 +32,23 @@ on:
 jobs:
   pre-commit:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
     steps:
     - uses: actions/checkout@v5.0.0
       with:
         fetch-depth: 2
-    - name: Get modified files
-      id: modified-files
-      run: echo "modified_files=$(git diff --name-only -r HEAD^1 HEAD | xargs)" >> $GITHUB_OUTPUT
     - uses: actions/setup-python@v6.0.0
-    - uses: pre-commit/action@v3.0.1
+    - uses: actions/cache@v4
       with:
-        extra_args: --files ${{ steps.modified-files.outputs.modified_files }}
+        path: ~/.cache/pre-commit
+        key: pre-commit-${{ runner.os }}-${{ hashFiles('.pre-commit-config.yaml') }}
+    - name: Run pre-commit on the files modified by the PR
+      # Null-delimited so paths with spaces survive; --no-run-if-empty
+      # handles deletion-only PRs; deleted paths are filtered out before
+      # being handed to pre-commit.
+      run: |
+        python -m pip install --quiet pre-commit
+        git diff --name-only -z --diff-filter=d HEAD^1 HEAD \
+          | xargs -0 --no-run-if-empty \
+            pre-commit run --show-diff-on-failure --color=always --files

.pre-commit-config.yaml

@@ -24,6 +24,8 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+default_install_hook_types: [pre-commit, commit-msg]
+
 repos:
 - repo: https://github.com/PyCQA/isort
   rev: 5.12.0
@@ -39,7 +41,7 @@ repos:
   rev: 7.3.0
   hooks:
   - id: flake8
-    args: [--max-line-length=88, --select=C,E,F,W,B,B950, --extend-ignore = E203,E501]
+    args: ["--max-line-length=88", "--select=C,E,F,W,B,B950", "--extend-ignore=E203,E501"]
     types_or: [python, cython]
 - repo: https://github.com/pre-commit/mirrors-clang-format
   rev: v16.0.5
@@ -54,6 +56,15 @@ repos:
     additional_dependencies: [tomli]
     args: ["--toml", "pyproject.toml"]
     exclude: (?x)^(.*stemmer.*|.*stop_words.*|^CHANGELOG.md$)
+# Validates commit messages against the Conventional Commits format
+# (<commit_type>: <title>); PR titles are validated org-wide by the
+# conventional-pr reusable workflow.
+- repo: https://github.com/compilerla/conventional-pre-commit
+  rev: v4.4.0
+  hooks:
+  - id: conventional-pre-commit
+    stages: [commit-msg]
+    args: [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]
 # More details about these pre-commit hooks here:
 # https://pre-commit.com/hooks.html
 - repo: https://github.com/pre-commit/pre-commit-hooks
@@ -72,7 +83,7 @@ repos:
   - id: requirements-txt-fixer
   - id: trailing-whitespace
 
-- repo: https://github.com/triton-inference-server/developer_tools
-  rev: v0.1.0
+- repo: https://github.com/triton-inference-server/.github
+  rev: v1.4.3
   hooks:
   - id: add-license