Skip to content

Update actions/upload-artifact to v7, docker/login-action to v4.6.0 - #280

Merged
ebyhr merged 2 commits into
trinodb:masterfrom
ebyhr:ebi/nodejs
Aug 21, 2026
Merged

Update actions/upload-artifact to v7, docker/login-action to v4.6.0#280
ebyhr merged 2 commits into
trinodb:masterfrom
ebyhr:ebi/nodejs

Conversation

@ebyhr

@ebyhr ebyhr commented Aug 20, 2026

Copy link
Copy Markdown
Member

Fix deprecated Node.js 20 warning message:

Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/upload-artifact@v4, docker/login-action@f4ef78c. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

https://github.com/trinodb/docker-images/actions/runs/32424244130

@cla-bot cla-bot Bot added the cla-signed label Aug 20, 2026
@ebyhr
ebyhr requested review from chenjian2664 and wendigo August 20, 2026 23:44

- name: Log in to the Container registry
uses: docker/login-action@f4ef78c080cd8ba55a85445d5b36e214a81df20a
uses: docker/login-action@dbcb813823bdd20940b903addbd779551569679f # v4.6.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably standardize on this more secure format across all Trino projects - ideally at least make it consistent in this flow. Could you start the discussion around this in the maintainer channel?

@ebyhr
ebyhr merged commit 3a52f66 into trinodb:master Aug 21, 2026
30 checks passed
@ebyhr
ebyhr deleted the ebi/nodejs branch August 21, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants