GitHub Actions Fixes - #401
Merged
Merged
Conversation
Analysis Details0 Issues
Coverage and Duplications
Project ID: Modus.trimble:Devguide |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates GitHub Actions workflows to use specific commit SHAs for action dependencies, enhancing security and reproducibility. It also introduces minor configuration changes for spell checking and linting.
CI/CD and Workflow Security Improvements:
Updated all uses of
actions/checkout,actions/setup-node,github/codeql-action,streetsidesoftware/cspell-action, andJustinBeckwith/linkinator-actionin workflow files to reference specific commit SHAs instead of version tags, ensuring deterministic and secure builds. Also addedpersist-credentials: falseto allactions/checkoutsteps to reduce the risk of credential leaks. (.github/workflows/azure-static-web-apps-deploy.yml, codeql-analysis.yml, dependency-review.yml, sonar-scan.yml, spellcheck.yml, super-linter.yml, test.yml) [1] [2] [3] [4] [5] [6] [7] [8]Updated
super-linterand related workflow steps to addVALIDATE_GITHUB_ACTIONS_ZIZMOR: false, disabling a specific linter check. (.github/workflows/super-linter.yml)Configuration and Spell Check Updates:
"ZIZMOR"to the list of allowed words in.cspell.jsonto prevent false positives in spell checking. (.cspell.json)Other Configuration Changes:
"space-tab-mixed-disabled": space,line from.htmlhintrc, likely to fix a misconfiguration or typo. (.htmlhintrc)