fix(webapp): derive expiry status from loader time - #4718
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🔍 Remaining client-side clock use in the new key dialog
expirationDate() still computes from client Date.now() (apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx:994-996), and the resulting hint is rendered in the create-key dialog. If that value is rendered during SSR as well as on the client it can produce the same class of mismatch this PR set out to remove; worth confirming it is only evaluated after user interaction.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Derives session and API key expiry states from a timestamp captured by each route loader. Every status on a page now uses one consistent point in time instead of changing according to when an individual component rerenders.