Skip to content

chore: prefer direct iteration and function callback types - #4677

Merged
carderne merged 1 commit into
chore/lint-remove-empty-blocks-tri-13381from
chore/lint-iteration-and-function-types-tri-13381
Aug 19, 2026
Merged

chore: prefer direct iteration and function callback types#4677
carderne merged 1 commit into
chore/lint-remove-empty-blocks-tri-13381from
chore/lint-iteration-and-function-types-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Enable lint rules that prefer direct iteration and concise function callback types.

The existing code now uses direct iteration where no index is needed, and callback contracts use function types consistently.

Base: #4675

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c9f48a6-3628-45a4-bc58-d0195b8e37ee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 387f85d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Aug 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@387f85d

trigger.dev

npm i https://pkg.pr.new/trigger.dev@387f85d

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@387f85d

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@387f85d

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@387f85d

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@387f85d

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@387f85d

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@387f85d

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@387f85d

commit: 387f85d

@carderne
carderne force-pushed the chore/lint-iteration-and-function-types-tri-13381 branch from f5cb10d to 387f85d Compare August 18, 2026 19:57
@carderne
carderne marked this pull request as ready for review August 18, 2026 21:10

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@carderne
carderne merged commit f432093 into main Aug 19, 2026
52 checks passed
@carderne
carderne deleted the chore/lint-iteration-and-function-types-tri-13381 branch August 19, 2026 07:29
carderne added a commit that referenced this pull request Aug 19, 2026
## Summary

Memoize shared context values so provider renders do not unnecessarily
rerender every consumer. Oxlint now enforces this pattern for the rest
of the dashboard.

Base: [#4677](#4677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants