chore: enable additional correctness lint rules

[carderne]

Summary

Enable additional lint rules that catch unsafe optional-chain assertions, inherited-property iteration, anonymous symbols, and unsafe external links.

The existing violations now use explicit values and own-property checks, so the rules can prevent those patterns from returning.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f30798dd-cbfa-4421-b599-afd814f66e58

📥 Commits

Reviewing files that changed from the base of the PR and between cffaa05 and 5a5e18a.

📒 Files selected for processing (12)

• .oxlintrc.json
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• apps/webapp/server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/core/src/v3/errors.ts
• packages/core/src/v3/locals/manager.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• packages/trigger-sdk/src/v3/ai.ts
• packages/trigger-sdk/src/v3/chat-client.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (36)

• GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
• GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
• GitHub Check: sdk-compat / Node.js 22.23 (warp-ubuntu-latest-x64-4x)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
• GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - pnpm)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
• GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - npm)
• GitHub Check: sdk-compat / Node.js 24.18 (warp-ubuntu-latest-x64-4x)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
• GitHub Check: sdk-compat / Node.js 26.4 (warp-ubuntu-latest-x64-4x)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
• GitHub Check: sdk-compat / Cloudflare Workers
• GitHub Check: sdk-compat / Deno Runtime
• GitHub Check: sdk-compat / Node.js 20.20 (warp-ubuntu-latest-x64-4x)
• GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - pnpm)
• GitHub Check: sdk-compat / Bun Runtime
• GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - npm)
• GitHub Check: internal / 🧪 Unit Tests: Internal
• GitHub Check: fk-cascade-guard / fk-cascade-guard
• GitHub Check: obsmap / 🧪 Unit Tests: Observability Map
• GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
• GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
• GitHub Check: runops-guard / runops-guard
• GitHub Check: typecheck / typecheck
• GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
• GitHub Check: code-quality / code-quality
• GitHub Check: 🛡️ E2E Auth Tests (full)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Build and publish previews

🧰 Additional context used

📓 Path-based instructions (13)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

**/*.{ts,tsx}: Prefer static imports over dynamic imports. Only use dynamic import() when:

• Circular dependencies cannot be resolved otherwise
• Code splitting is genuinely needed for performance
• The module must be loaded conditionally at runtime
  Zod is pinned to a single version across the entire monorepo (currently 3.25.76). When adding zod to a new or existing package, use the exact same version as the rest of the repo - never a different version or a range. Mismatched zod versions cause runtime type incompatibilities (e.g., schemas from one package can't be used as body validators in another).
  Do not reintroduce V1.
  Add crumbs as you write code — not just when debugging.
  Do not invent new namespaces — pick from this table or ask first.

Files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

{packages/core,apps/webapp}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use zod for validation in packages/core and apps/webapp

Files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)

**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries

Files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

packages/core/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (packages/core/CLAUDE.md)

Never import the root package (@trigger.dev/core). Always use subpath imports such as @trigger.dev/core/v3, @trigger.dev/core/v3/utils, @trigger.dev/core/logger, or @trigger.dev/core/schemas

Files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• packages/core/src/v3/apiClient/core.ts
• packages/core/src/v3/locals/manager.ts

packages/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

packages/**/*.{ts,tsx}: - Public packages (packages/*): Use build.
Always import from @trigger.dev/sdk. Never use @trigger.dev/sdk/v3 or deprecated client.defineJob.

Files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

packages/core/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

• packages/core (@trigger.dev/core): Shared types. Import subpaths only (never root).

Files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• packages/core/src/v3/apiClient/core.ts
• packages/core/src/v3/locals/manager.ts

apps/webapp/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

apps/webapp/**/*.{ts,tsx}: Access environment variables through the env export of env.server.ts instead of directly accessing process.env
Use subpath exports from @trigger.dev/core package instead of importing from the root @trigger.dev/core path

Files:

• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts

apps/webapp/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

apps/webapp/app/**/*.{ts,tsx}: For dashboard changes, visually verify the running Remix app with Chrome DevTools MCP, using snapshots, screenshots, interaction, and console-message checks as appropriate.
Use useCallback and useMemo only for context provider values, expensive derived data used as a dependency, or stable references required by dependency arrays; do not wrap ordinary event handlers or trivial computations.
Use named constants for sentinel or placeholder values instead of scattering raw string literals across comparisons.

Files:

• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts

apps/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

apps/**/*.{ts,tsx}: - Apps and internal packages (apps/*, internal-packages/*): Use typecheck. Never use build for these — building proves almost nothing about correctness.
Always import from @trigger.dev/sdk. Never use @trigger.dev/sdk/v3 or deprecated client.defineJob.

Files:

• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts

apps/webapp/app/**/*.ts

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

apps/webapp/app/**/*.ts: Never use request.signal to detect client disconnects. Use getRequestAbortSignal() from app/services/httpAsyncStorage.server.ts, which is wired to Express response close events.
Access environment variables through the env export from app/env.server.ts; never use process.env directly.
Always use Prisma findFirst instead of findUnique.
Always use the $transaction helper from ~/db.server, never call prisma.$transaction or $replica.$transaction directly. Pass isolation levels as strings, use Serializable for correctness-critical read-then-write invariants, and guard possibly undefined helper results when a definite value is required.

Files:

• apps/webapp/app/services/metadata/updateMetadata.server.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts

packages/trigger-sdk/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

In the Trigger.dev SDK (packages/trigger-sdk), prefer isomorphic code like fetch and ReadableStream instead of Node.js-specific code

Files:

• packages/trigger-sdk/src/v3/ai.ts
• packages/trigger-sdk/src/v3/chat-client.ts

packages/trigger-sdk/**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (packages/trigger-sdk/CLAUDE.md)

Always import from @trigger.dev/sdk. Never use @trigger.dev/sdk/v3 (deprecated path alias)

Files:

• packages/trigger-sdk/src/v3/ai.ts
• packages/trigger-sdk/src/v3/chat-client.ts

🧠 Learnings (30)

📓 Common learnings

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3963
File: packages/trigger-sdk/src/v3/ai.ts:10136-10141
Timestamp: 2026-06-16T12:35:11.681Z
Learning: In `packages/trigger-sdk/src/v3/ai.ts`, when assembling `SessionTriggerConfig` for `chat.createStartSessionAction`, string-like optional trigger config fields such as `queue`, `machine`, `region`, and `lockToVersion` intentionally use truthiness checks because empty strings are not valid values. Numeric optional fields such as `maxAttempts`, `maxDuration`, and `idleTimeoutInSeconds` should use `!== undefined` so valid numeric falsy values are preserved. Do not flag `lockToVersion` for using a truthiness check in this assembly.

📚 Learning: 2026-04-13T21:43:58.707Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3368
File: apps/webapp/app/services/taskIdentifierRegistry.server.ts:49-58
Timestamp: 2026-04-13T21:43:58.707Z
Learning: In `apps/webapp/app/services/taskIdentifierRegistry.server.ts` (and closely related task registry/sync code in this module), an empty deployment (zero tasks) is not a realistic/expected scenario. Do not flag or require special handling or fallback logic for missing empty-task cases in this registry/sync flow.

Applied to files:

• .oxlintrc.json

📚 Learning: 2026-04-23T13:26:27.529Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3430
File: apps/webapp/app/presenters/v3/RunStreamPresenter.server.ts:0-0
Timestamp: 2026-04-23T13:26:27.529Z
Learning: In this codebase’s SSE implementation (notably `apps/webapp/app/utils/sse.ts` and its SSE callers such as `apps/webapp/app/presenters/v3/RunStreamPresenter.server.ts`), do not treat `.abort()` vs `.abort("<reason string>")` differences as a heap retention/memory leak issue on Node 20. Heap deltas are identical once `AbortSignal.any` is not involved; the investigated SSE memory leak root cause was `AbortSignal.any` (via FinalizationRegistry behavior on abort). When reviewing, focus on whether `AbortSignal.any` (or similar signal-combining/finalization patterns) is used in the SSE abort path rather than the presence/contents of the abort reason string. Named abort-reason sentinel constants (e.g., `ABORT_REASON_*`) are for readability/style only, not correctness.

Applied to files:

• .oxlintrc.json

📚 Learning: 2026-04-30T21:28:35.705Z

Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3473
File: internal-packages/database/prisma/schema.prisma:59-60
Timestamp: 2026-04-30T21:28:35.705Z
Learning: In this repo, session-duration lower-bound validation is intentionally enforced only at the app layer (via `isAllowedSessionDuration` and `SESSION_DURATION_OPTIONS`), where the minimum allowed value is 300 seconds (5 minutes). `User.sessionDuration` is `Int` (non-nullable) and `Organization.maxSessionDuration` is `Int?` (nullable). There are currently no DB-level `CHECK` constraints for these fields anywhere in the migrations, so future reviews should not flag the absence of DB `CHECK` constraints on these session-duration fields—focus validation on the app-layer logic instead.

Applied to files:

• .oxlintrc.json

📚 Learning: 2026-05-12T06:43:09.116Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3558
File: internal-packages/run-engine/src/run-queue/index.ts:420-424
Timestamp: 2026-05-12T06:43:09.116Z
Learning: In internal-packages/run-engine/src/run-queue/index.ts, the RunQueue “read-path” counter/concurrency methods (e.g., lengthOfQueue/lengthOfQueues/currentConcurrencyOfQueues) intentionally “fail open” on transient Redis pipeline result errors. If you see pipeline result errors (e.g., baseErr/ctrErr) being coerced to 0 (treating Redis command errors the same as missing keys) rather than surfaced/thrown, do not flag it as a bug and do not suggest propagating those errors in future reviews.

Applied to files:

• .oxlintrc.json

📚 Learning: 2026-05-19T21:04:49.990Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3671
File: packages/trigger-sdk/src/v3/ai.ts:724-769
Timestamp: 2026-05-19T21:04:49.990Z
Learning: In packages/trigger-sdk/src/v3/ai.ts, when reviewing recovery/replay of turns, do NOT flag “lost metadata on recovered turns” if the recovered turns are reconstructed via the recovery boot queue that maps metadata by message.id (using replaySessionInTail’s {message, metadata, seqNum} per session.in record). If a message has no matching session.in record (e.g., hook-synthesized messages), the code intentionally falls back to the current boot payload’s metadata—this fallback is expected behavior.

Applied to files:

• .oxlintrc.json

📚 Learning: 2026-03-22T13:26:12.060Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).

Applied to files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-03-22T19:24:14.403Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.

Applied to files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-05-18T08:21:27.694Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.

Applied to files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-05-18T08:21:27.694Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.

Applied to files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-06-13T19:53:13.759Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.

Applied to files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-06-17T17:13:49.929Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).

Applied to files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-06-23T13:04:21.413Z

Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.

Applied to files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-06-04T18:16:35.386Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.

Applied to files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-06-09T17:58:04.699Z

Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.

Applied to files:

• packages/core/src/v3/errors.ts
• packages/core/src/v3/serverOnly/httpServer.ts
• packages/core/src/v3/utils/flattenAttributes.ts
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• packages/core/src/v3/apiClient/core.ts
• packages/trigger-sdk/src/v3/ai.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts
• packages/core/src/v3/locals/manager.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-02-11T16:37:32.429Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3019
File: apps/webapp/app/components/primitives/charts/Card.tsx:26-30
Timestamp: 2026-02-11T16:37:32.429Z
Learning: In projects using react-grid-layout, avoid relying on drag-handle class to imply draggability. Ensure drag-handle elements only affect dragging when the parent grid item is configured draggable in the layout; conditionally apply cursor styles based on the draggable prop. This improves correctness and accessibility.

Applied to files:

• apps/webapp/app/components/primitives/Callout.tsx

📚 Learning: 2026-07-28T21:57:20.061Z

Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 4411
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.team/route.tsx:818-843
Timestamp: 2026-07-28T21:57:20.061Z
Learning: When using Radix UI `DialogClose` with `asChild` (e.g., Trigger.dev dashboard components), note that it injects `type="button"` into its child via `Slot`. If the child is a local `Button` that forwards its `type` prop to the native `<button>`, then placing it inside a `<form>` will *not* submit unless you explicitly set `type="submit"` (or otherwise override the injected type / wire up submission behavior). Review form actions to ensure the intended submit vs non-submit behavior is preserved.

Applied to files:

• apps/webapp/app/components/primitives/Callout.tsx

📚 Learning: 2026-04-16T14:21:15.229Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3368
File: apps/webapp/app/components/logs/LogsTaskFilter.tsx:135-163
Timestamp: 2026-04-16T14:21:15.229Z
Learning: When rendering lists of task registry items in apps/webapp (e.g., <SelectItem /> rows) and using `key={item.slug}`, do not flag it as potentially non-unique. In trigger.dev’s `TaskIdentifier` table, the DB constraint `@unique([runtimeEnvironmentId, slug])` guarantees `slug` is unique within a given runtime environment, so `item.slug` is safe as the React key as long as the list is derived from that registry/constraint (and not from a legacy query that could produce duplicate slugs).

Applied to files:

• apps/webapp/app/components/primitives/Callout.tsx

📚 Learning: 2026-05-08T21:00:20.973Z

Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3538
File: apps/webapp/app/components/primitives/Resizable.tsx:60-78
Timestamp: 2026-05-08T21:00:20.973Z
Learning: In the triggerdotdev/trigger.dev codebase, treat Zod as a boundary validation tool (API handlers, request/response validation, and storage/DB read/write validation), not as inline render-time validation inside React components/primitive UI code. For render-time guards, prefer small manual type-narrowing checks (e.g., a short predicate like ~10–20 lines) over importing Zod into UI primitives, to avoid per-render schema-parse overhead and unnecessary abstraction. Use the manual guard approach unless you truly need schema validation at a boundary; only then introduce Zod.

Applied to files:

• apps/webapp/app/components/primitives/Callout.tsx

📚 Learning: 2026-06-25T18:21:55.847Z

Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-resend.tsx:0-0
Timestamp: 2026-06-25T18:21:55.847Z
Learning: In the triggerdotdev/trigger.dev Zod 4 migration, avoid importing from the root package `conform-to/zod` in webapp code. It can resolve to the Zod 3 build and may crash at module load under Zod 4. When reviewing TypeScript/TSX files in `apps/webapp`, prefer importing from the Zod 4 subpath `conform-to/zod/v4` for Zod 4-compatible schemas/types.

Applied to files:

• apps/webapp/app/components/primitives/Callout.tsx

📚 Learning: 2026-05-12T21:04:05.815Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.

Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.

Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.

Applied to files:

• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts

📚 Learning: 2026-06-25T18:21:51.905Z

Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.

Applied to files:

• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts

📚 Learning: 2026-07-03T17:10:21.498Z

Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.

Applied to files:

• apps/webapp/app/components/primitives/Callout.tsx
• apps/webapp/server.ts
• apps/webapp/app/services/metadata/updateMetadata.server.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts

📚 Learning: 2026-06-25T18:21:54.729Z

Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/confirm-basic-details.tsx:0-0
Timestamp: 2026-06-25T18:21:54.729Z
Learning: For Remix + TypeScript files that use Conform v1 (conform-to/react) and its getInputProps helper, when you intend to suppress the helper-provided default value for non-checkbox/non-radio inputs (e.g., hidden inputs managed via an explicit value prop), use the Conform v1 option key `value: false`. Do not recommend `defaultValue: false` here, because `defaultValue` is not a valid option key for these input types in Conform v1 typings.

Applied to files:

• apps/webapp/app/components/primitives/Callout.tsx

📚 Learning: 2026-03-26T09:02:07.973Z

Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3274
File: apps/webapp/app/services/runsReplicationService.server.ts:922-924
Timestamp: 2026-03-26T09:02:07.973Z
Learning: When parsing Trigger.dev task run annotations in server-side services, keep `TaskRun.annotations` strictly conforming to the `RunAnnotations` schema from `trigger.dev/core/v3`. If the code already uses `RunAnnotations.safeParse` (e.g., in a `#parseAnnotations` helper), treat that as intentional/necessary for atomic, schema-accurate annotation handling. Do not recommend relaxing the annotation payload schema or using a permissive “passthrough” parse path, since the annotations are expected to be written atomically in one operation and should not contain partial/legacy payloads that would require a looser parser.

Applied to files:

• apps/webapp/app/services/metadata/updateMetadata.server.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts

📚 Learning: 2026-05-05T09:38:02.512Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.

Applied to files:

• apps/webapp/app/services/metadata/updateMetadata.server.ts
• apps/webapp/app/services/routeBuilders/permissions.server.ts

📚 Learning: 2026-03-31T21:37:27.212Z

Learnt from: isshaddad
Repo: triggerdotdev/trigger.dev PR: 3283
File: docs/migration-n8n.mdx:19-21
Timestamp: 2026-03-31T21:37:27.212Z
Learning: When reviewing code in `packages/trigger-sdk/src/v3`, treat `tasks.triggerAndWait()` and `tasks.batchTriggerAndWait()` as real exported APIs. They are defined in `shared.ts` and re-exported via the `tasks` object in `tasks.ts`, and they take the task ID string as their first argument (not a task instance). This is distinct from the instance methods `yourTask.triggerAndWait()` and `yourTask.batchTriggerAndWait()`. Do not flag calls to `tasks.triggerAndWait()` or `tasks.batchTriggerAndWait()` as non-existent or incorrectly invoked.

Applied to files:

• packages/trigger-sdk/src/v3/ai.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-05-17T08:08:12.370Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3644
File: packages/trigger-sdk/src/v3/ai.ts:8695-8746
Timestamp: 2026-05-17T08:08:12.370Z
Learning: In the Trigger v3 session resume/streams logic, ensure session resumption uses sequence cursors rather than timestamps. Specifically: for each turn-complete control record written to `session.out`, include a `session-in-event-id` header whose value is the committed-consume cursor (`session.in.lastDispatchedSeqNum`). On boot/resume, scan `session.out` for the latest turn-complete record, read the `session-in-event-id` header, and seed the `sessionStreams` manager for `.in` using both `lastSeqNum` and `lastDispatchedSeqNum` so previously processed user messages are not replayed. Do not use `setMinTimestamp`/`lastOutTimestamp` for resume ordering in this flow.

Applied to files:

• packages/trigger-sdk/src/v3/ai.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-05-18T14:19:56.437Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3655
File: packages/trigger-sdk/src/v3/ai.ts:8667-8731
Timestamp: 2026-05-18T14:19:56.437Z
Learning: In the Trigger SDK (v3) when making raw `fetch` calls to the Trigger API (including override paths such as `createChatStartSessionAction`), set the request headers to match `ApiClient`: `Content-Type`, `Authorization`, and `x-trigger-source: "sdk"`. Also forward the current preview branch by setting `x-trigger-branch` to `apiClientManager.branchName`. Prefer using the shared `overrideRequestHeaders(accessToken)` helper instead of manually constructing headers, so requests route correctly to preview environments.

Applied to files:

• packages/trigger-sdk/src/v3/ai.ts
• packages/trigger-sdk/src/v3/chat-client.ts

📚 Learning: 2026-05-19T22:37:47.286Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3671
File: packages/trigger-sdk/test/recovery-boot.test.ts:456-457
Timestamp: 2026-05-19T22:37:47.286Z
Learning: In `packages/trigger-sdk` (Trigger.dev SDK), `logger.warn` (and other SDK logger methods) should route to the Trigger.dev structured logger sink, not to `console.warn`. In SDK tests, `vi.spyOn(console, "warn")` (or similar console spies) should only be used to suppress stray console output; reviewers should not suggest asserting on `console.warn` spies to verify SDK-internal warning/fallback log behavior. Use the SDK’s structured-logger outputs/capture approach instead of console spies.

Applied to files:

• packages/trigger-sdk/src/v3/ai.ts
• packages/trigger-sdk/src/v3/chat-client.ts

🔇 Additional comments (12)

.oxlintrc.json (1)

37-37: LGTM!

Also applies to: 50-52

apps/webapp/app/components/primitives/Callout.tsx (1)

95-95: LGTM!

apps/webapp/app/services/metadata/updateMetadata.server.ts (1)

592-592: LGTM!

packages/core/src/v3/locals/manager.ts (1)

6-6: LGTM!

apps/webapp/app/services/routeBuilders/permissions.server.ts (1)

32-32: LGTM!

apps/webapp/server.ts (1)

40-40: LGTM!

packages/core/src/v3/apiClient/core.ts (1)

608-610: LGTM!

packages/core/src/v3/errors.ts (1)

1175-1175: LGTM!

packages/core/src/v3/serverOnly/httpServer.ts (1)

349-349: LGTM!

packages/core/src/v3/utils/flattenAttributes.ts (1)

349-349: LGTM!

packages/trigger-sdk/src/v3/ai.ts (1)

10447-10450: LGTM!

Also applies to: 10468-10469, 10479-10479

packages/trigger-sdk/src/v3/chat-client.ts (1)

656-657: LGTM!

Also applies to: 678-678

---

Walkthrough

The Oxlint configuration now enables four rules as errors. Runtime code adds rel="noreferrer", removes optional chaining from a metadata write, and uses local IDs as symbol descriptions. Several object iterations now process only own properties. Chat session code resolves per-call trigger settings before defaults and conditionally adds defined values to the session trigger configuration.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The description includes a relevant summary but omits the required checklist, testing, changelog, screenshots, and issue reference.	Add the required template sections and provide testing steps, changelog details, screenshots or an explicit not-applicable note, and the issue reference.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: enabling additional correctness lint rules.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/enable-lint-correctness-tri-13381

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.