Lower the patch-coverage gate from 80% to 75% - #154
Merged
Conversation
Matches the absolute project floor coverage-gate.sh already enforces, so a branch that clears the codebase-wide bar is no longer failed for clearing it by less than the patch gate wanted. Applied across every repo running this mechanism so the gate means the same thing everywhere. The two numbers were deliberately different — new code held higher than inherited debt — so this does give that up, and the header now says so rather than leaving the old rationale describing a split that no longer exists. Running both scripts still earns its keep on the QUESTION each asks: a branch can sit comfortably above the project floor while the handful of lines it actually changed go untested, and only the patch gate sees that. Both the gate and the log line read PATCH_MIN, so the printed threshold follows automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hack/patch-coverage.sh'sPATCH_MINgoes 80 → 75, matching the absolute project floorhack/coverage-gate.shalready enforces. Applied across every repo running this mechanism, so the gate means the same thing everywhere.What this gives up, stated plainly: the two numbers were different on purpose — new code held to a higher bar (80) than inherited debt (75). They're now the same, so that distinction is gone. The header comment has been rewritten to say so rather than leaving the old rationale describing a split that no longer exists.
Why running both scripts still earns its keep: the questions differ even when the numbers don't. A branch can sit comfortably above the project floor while the handful of lines it actually changed go untested — the floor can't see that, the patch gate can.
Both the
--fail-underand the printed== ... patch coverage (>= N%) ==header readPATCH_MIN, so the log follows automatically. No CI workflow change needed.