Relabel file:// whitelist example as 'Local list file' - #124
Merged
Conversation
The previous "External list" label was misleading — file:// URLs point at a local file. The comment block above WHITELIST already explains that the local file is how you incorporate IPs sourced from external systems out-of-band.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The inline comment on the example
file://whitelist entry called it an "External list", which contradicts the rest of the WHITELIST documentation. The header above the array explicitly tells users to fetch external sources out-of-band into a local file and reference it withfile://. So the file is local — only its source data is external. Relabel to "Local list file".Test plan