Repository navigation
fix(query_builder): keep working on pydal 3 as well as current pydal - #20
Closed
robinvandernoord wants to merge 1 commit into
Closed
robinvandernoord wants to merge 1 commit into
robinvandernoord wants to merge 1 commit into
Conversation
- QueryBuilder in belongs(): pydal 3 compiles subselects from Select._db/_query/_attributes instead of calling _compile(). Expose the same (query, fields, kwargs) that to_sql() renders, so relationship handling is preserved. - distinct=(a, b): pre-join the normalized names into one fragment; pydal 3 runs xorify() on lists, which fails on plain strings. - _insert/_update/_delete: return pydal's result unchanged instead of str(), so bound params (pydal 3 ParamSQL) are not stripped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WnVuQ2ohUGVQ33KvucZYk6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of calling _compile(). Expose the same (query, fields, kwargs) that to_sql() renders,
so relationship handling is preserved.
on lists, which fails on plain strings.
(pydal 3 ParamSQL) are not stripped.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01WnVuQ2ohUGVQ33KvucZYk6