feat(suite-native): replace max button with toggle in yield flows - #32189
Merged
Conversation
TomasBoda
force-pushed
the
feat/native/yield-max-toggle
branch
2 times, most recently
from
September 7, 2026 14:07
e51943c to
67e7330
Compare
tomasklim
previously requested changes
Sep 7, 2026
izmy
approved these changes
Sep 7, 2026
Contributor
|
✅ Previously successful run of [Test] suite-native Android E2E workflow has been found. |
TomasBoda
force-pushed
the
feat/native/yield-max-toggle
branch
from
September 8, 2026 07:49
6a23f4c to
a3d815e
Compare
TomasBoda
force-pushed
the
feat/native/yield-max-toggle
branch
from
September 8, 2026 08:02
d06ffd8 to
1a333c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
Maxbutton with a toggle in yield flows.Related Issue
Resolve #31297
Screenshots:
🤖 LLM Test Recommendations
Summary: The change set is concentrated in the earn/yield approval and amount-resolution logic. The primary regression risk is in web Suite yield withdrawal and redeem flows, so the two yield E2E tests are the highest-value coverage. The remaining changed files are suite-native mobile components or unit-test files that are not exercised by the suite-web E2E suite and have no inferred E2E coverage.
Changed files (8)
packages/suite/src/components/earn/yield/common/YieldApproveModal.tsxsuite-common/wallet-core/src/yield/utils/getResolvedYieldFlowData.test.tssuite-common/wallet-core/src/yield/utils/getResolvedYieldFlowData.tssuite-native/intl/src/messages.tssuite-native/module-earn/src/components/earn/EarnMaxSwitch.tsxsuite-native/module-earn/src/components/earn/WrappedNativeTokenAmountInputCard.tsxsuite-native/module-earn/src/components/yield/YieldAmountInputCard.tsxsuite-native/module-earn/src/screens/yield/YieldWithdrawScreen.tsxRecommended tests (2)
🔴 High priority (2)
suite/e2e/tests/yield/redeem.test.ts— This test walks through the USDC Prime Vault redeem flow, including the approval/redeem modal and amount resolution. Changes to YieldApproveModal and getResolvedYieldFlowData directly affect how the vault share amount, price-per-share conversion, and fee are computed and presented in this flow.suite/e2e/tests/yield/withdrawal.test.ts— This test exercises the yield withdrawal flow from the earn dashboard through device confirmation. getResolvedYieldFlowData is used to resolve withdrawal amounts and asset conversions, so a regression here would be visible in the amount, fee, and summary values the test asserts.suite-common/wallet-core/src/yield/utils/getResolvedYieldFlowData.test.tssuite-native/intl/src/messages.tssuite-native/module-earn/src/components/earn/EarnMaxSwitch.tsxsuite-native/module-earn/src/components/earn/WrappedNativeTokenAmountInputCard.tsxsuite-native/module-earn/src/components/yield/YieldAmountInputCard.tsxsuite-native/module-earn/src/screens/yield/YieldWithdrawScreen.tsxUpdated: 2026-09-08T08:06:25.644Z
🌐 Preview deployments
🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/feat/native/yield-max-toggle/web/
🔍 Currents Test Results
🔍 Suite web test results: View in Currents
🔍 Suite desktop test results: View in Currents
🔍 Suite native android test results: View in Currents
🔒 Quarantined E2E Tests
Trezor Suite (desktop) — 4 test(s)
Updated: 2026-09-08T08:08:21.407Z • 4 test(s) total
Trezor Suite (web) — 4 test(s)
Updated: 2026-09-08T08:09:28.275Z • 4 test(s) total