Skip to content

feat(suite-native): replace max button with toggle in yield flows - #32189

Merged
TomasBoda merged 2 commits into
developfrom
feat/native/yield-max-toggle
Sep 8, 2026
Merged

feat(suite-native): replace max button with toggle in yield flows#32189
TomasBoda merged 2 commits into
developfrom
feat/native/yield-max-toggle

Conversation

@TomasBoda

@TomasBoda TomasBoda commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

Replace Max button with a toggle in yield flows.

Related Issue

Resolve #31297

Screenshots:

Simulator Screenshot - iPhone 17 - 2026-09-07 at 15 49 49 Simulator Screenshot - iPhone 17 - 2026-09-07 at 15 50 41 Simulator Screenshot - iPhone 17 - 2026-09-07 at 15 51 16
Simulator Screenshot - iPhone 17 - 2026-09-07 at 15 52 01 Simulator Screenshot - iPhone 17 - 2026-09-07 at 15 52 32

🤖 LLM Test Recommendations

Summary: The change set is concentrated in the earn/yield approval and amount-resolution logic. The primary regression risk is in web Suite yield withdrawal and redeem flows, so the two yield E2E tests are the highest-value coverage. The remaining changed files are suite-native mobile components or unit-test files that are not exercised by the suite-web E2E suite and have no inferred E2E coverage.

Changed files (8)
  • packages/suite/src/components/earn/yield/common/YieldApproveModal.tsx
  • suite-common/wallet-core/src/yield/utils/getResolvedYieldFlowData.test.ts
  • suite-common/wallet-core/src/yield/utils/getResolvedYieldFlowData.ts
  • suite-native/intl/src/messages.ts
  • suite-native/module-earn/src/components/earn/EarnMaxSwitch.tsx
  • suite-native/module-earn/src/components/earn/WrappedNativeTokenAmountInputCard.tsx
  • suite-native/module-earn/src/components/yield/YieldAmountInputCard.tsx
  • suite-native/module-earn/src/screens/yield/YieldWithdrawScreen.tsx

Recommended tests (2)

🔴 High priority (2)
  • suite/e2e/tests/yield/redeem.test.ts — This test walks through the USDC Prime Vault redeem flow, including the approval/redeem modal and amount resolution. Changes to YieldApproveModal and getResolvedYieldFlowData directly affect how the vault share amount, price-per-share conversion, and fee are computed and presented in this flow.
  • suite/e2e/tests/yield/withdrawal.test.ts — This test exercises the yield withdrawal flow from the earn dashboard through device confirmation. getResolvedYieldFlowData is used to resolve withdrawal amounts and asset conversions, so a regression here would be visible in the amount, fee, and summary values the test asserts.

⚠️ Changes with no test coverage (6)

  • suite-common/wallet-core/src/yield/utils/getResolvedYieldFlowData.test.ts
  • suite-native/intl/src/messages.ts
  • suite-native/module-earn/src/components/earn/EarnMaxSwitch.tsx
  • suite-native/module-earn/src/components/earn/WrappedNativeTokenAmountInputCard.tsx
  • suite-native/module-earn/src/components/yield/YieldAmountInputCard.tsx
  • suite-native/module-earn/src/screens/yield/YieldWithdrawScreen.tsx

Updated: 2026-09-08T08:06:25.644Z

🌐 Preview deployments

🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/feat/native/yield-max-toggle/web/

🔍 Currents Test Results

🔍 Suite web test results: View in Currents

🔍 Suite desktop test results: View in Currents

🔍 Suite native android test results: View in Currents

🔒 Quarantined E2E Tests

Trezor Suite (desktop) — 4 test(s)
Test Type
Staking - Cardano > Stake Cardano 🤖 auto
Suite Sync - Update and Remove Labels > Update and remove labels syncs correctly to relay 🤖 auto
Quarantine test: "Suite Sync - Quota Manager top-up,Exceeded wallet limit is topped up from the device pool" 🙋 manual
Trading - Swap > Swap SOL USDT token to ETH 🤖 auto

Updated: 2026-09-08T08:08:21.407Z • 4 test(s) total

Trezor Suite (web) — 4 test(s)
Test Type
Suite Sync - Update and Remove Labels > Update and remove labels syncs correctly to relay 🤖 auto
Trading - Swap > Swap SOL USDT token to ETH 🤖 auto
Trading - Swap coin to token > Swap Solana to USDC 🤖 auto
Quarantine test: "Recovery T2T1 - dry run,Recovery after partial recovery" 🙋 manual

Updated: 2026-09-08T08:09:28.275Z • 4 test(s) total

@TomasBoda TomasBoda self-assigned this Sep 7, 2026
@TomasBoda
TomasBoda force-pushed the feat/native/yield-max-toggle branch 2 times, most recently from e51943c to 67e7330 Compare September 7, 2026 14:07
Comment thread suite-native/intl/src/messages.ts Outdated
@trezor-bot

trezor-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

✅ Previously successful run of [Test] suite-native Android E2E workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@TomasBoda
TomasBoda force-pushed the feat/native/yield-max-toggle branch from 6a23f4c to a3d815e Compare September 8, 2026 07:49
@TomasBoda
TomasBoda requested a review from tomasklim September 8, 2026 07:49
@TomasBoda
TomasBoda force-pushed the feat/native/yield-max-toggle branch from d06ffd8 to 1a333c2 Compare September 8, 2026 08:02
@TomasBoda
TomasBoda merged commit efa17f6 into develop Sep 8, 2026
35 of 37 checks passed
@TomasBoda
TomasBoda deleted the feat/native/yield-max-toggle branch September 8, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fiat balance for deposit/withdraw amount screen is redundant

3 participants